Upgrade package to the latest. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy840119
added
package
|
remaining things:
|
andy840119
commented
Mar 19, 2023
Comment on lines
+34
to
+37
| // todo: think about how to upload the texture. | ||
| // Texture.Bind(1); | ||
| // var unitId = TextureUnit.Texture1 - TextureUnit.Texture0; | ||
| // GetUniform<int>(@"g_RepeatSample").UpdateValue(ref unitId); |
There was a problem hiding this comment.
Oops.
- should deal with upload the texture to the shader also.
There was a problem hiding this comment.
Note that it's follow the code in the ppy/osu-framework@9ec6711#diff-ec8681ce3076c551c70eeebdc49697c9efb11b7d6f1e10bf0240235dbff7f7d3R122-R138
But it's removed 😢
There was a problem hiding this comment.
Will leave this broken part to the #323 because it might be hard to fix now.
andy840119
force-pushed
the
upgrade-package-to-the-latest
branch
from
069aa20 to
7e607bb
Compare
Co-authored-by: WebFreak001 <[email protected]>
Co-authored-by: WebFreak001 <[email protected]>
Co-authored-by: WebFreak001 <[email protected]>
Co-authored-by: WebFreak001 <[email protected]>
Co-authored-by: WebFreak001 <[email protected]>
…st project. And note that this runner only create if not open the visual test windows.
andy840119
force-pushed
the
upgrade-package-to-the-latest
branch
from
7e607bb to
c0fa63f
Compare
|
Guess should be OK to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the latest osu-framework and upgrade shaders to new spir-v.
Here's another PR that doing the same things:
#321
Here's the change about the shader:
https://github.com/ppy/osu-framework/releases/tag/2023.314.0